-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify size op impl #45808
Merged
Merged
Simplify size op impl #45808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
LiYuRio
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for collective.py
YuanRisheng
approved these changes
Sep 9, 2022
chenwhql
added a commit
to chenwhql/Paddle
that referenced
this pull request
Sep 18, 2022
This reverts commit c252b1d.
chenwhql
added a commit
that referenced
this pull request
Sep 19, 2022
phlrain
pushed a commit
that referenced
this pull request
Sep 19, 2022
JiabinYang
added a commit
that referenced
this pull request
Sep 20, 2022
JiabinYang
added a commit
to JiabinYang/Paddle
that referenced
this pull request
Sep 20, 2022
* fix linspace error in amp * fix log * fix amp error * Revert "Simplify size op impl (PaddlePaddle#45808)" This reverts commit c252b1d. * fix_seg * fix detection Co-authored-by: Chen Weihang <sunny_cwh@163.com>
phlrain
pushed a commit
that referenced
this pull request
Sep 20, 2022
* [Eager] Fix ocr (#46124) * fix linspace error in amp * fix log * fix amp error * fix ocr error which caused by amp * add more check * rename dtype ns * [Eager Bug fix]Fix Detection (#46147) * fix linspace error in amp * fix log * fix amp error * Revert "Simplify size op impl (#45808)" This reverts commit c252b1d. * fix_seg * fix detection Co-authored-by: Chen Weihang <sunny_cwh@163.com> Co-authored-by: Chen Weihang <sunny_cwh@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
Simplify size op impl
paddle.numel() 即 size op返回的size是一个scalar值,应该始终放在CPU上,避免不必要的copy